Re: [patch 06/11] PAT x86: Refactoring i386 cpa

From: Ingo Molnar
Date: Mon Jan 14 2008 - 11:48:55 EST



* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> venkatesh.pallipadi@xxxxxxxxx writes:
>
> > This makes 32 bit cpa similar to x86_64 and makes it easier for
> > following PAT patches.
>
> Please don't do this -- that would be a nightmare merging with my CPA
> series.
>
> This means adding the _addr() entry point is ok (although it should
> not be needed on i386 because it doesn't do the end_pfn_mapped trick),
> but not a wide scale refactoring.

yeah, i think we can unify after your cpa fixes and enhancements just
fine - as you did the changes symmetrically for 32-bit and 64-bit.
Hopefully i'll be able to upload the current PAT stuff in x86.git later
today so that you can merge the cpa items ontop of it.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/