Re: [PATCH 1/2] checkstack: parse architecture correctly

[Jiri Slaby]

On 01/14/2008 08:19 PM, Stephen Hemminger wrote:
> The checkstack script wouldn't work because it was picking up the
> newline on the end of the output of uname -m.
>
> Also, use a standard perl construct to print error message and
> exit with non-zero error code.
>
> Signed-off-by: Stephen Hemminger <stephen.hemminger@xxxxxxxxxx>
>
> --- a/scripts/checkstack.pl	2008-01-14 11:09:09.000000000 -0800
> +++ b/scripts/checkstack.pl	2008-01-14 11:09:51.000000000 -0800
[...]
> -		print("wrong or unknown architecture\n");
> -		exit
> +	    	die "wrong or unknown architecture\"$arch\"\n";

a space before the variable would be good, maybe qq() instead of "" to avoid 
backslashing? Also the \n is reduntant there, otherwise you will loose the 
file+line info.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/