Re: rlim in proc/<pid>/status

[KOSAKI Motohiro]

Hi

sound good for me.
a few question please.

> +	for (i=0; i<RLIM_NLIMITS; i++) {
> +		if (rlim_names[i])
> +			buffer += sprintf(buffer, "Rlim%s:\t", rlim_names[i]);
> +		else
> +			buffer += sprintf(buffer, "Rlim%d:\t", i);

this else is really necessary?

> +		if (rlim[i].rlim_cur != ~0)
> +			buffer += sprintf(buffer, "%lu\t", rlim[i].rlim_cur);
> +		else
> +			buffer += sprintf(buffer, "-\t");
> +		if (rlim[i].rlim_max != ~0)
> +			buffer += sprintf(buffer, "%lu\n", rlim[i].rlim_max);
> +		else
> +			buffer += sprintf(buffer, "-\n");

Why do you don't use RLIM_INFINITY?

- kosaki


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/