Re: hrtimer.c devinit vs. cpuinit

[Sam Ravnborg]

On Tue, Jan 15, 2008 at 01:30:10AM +0100, Johannes Berg wrote:
> Hi,
> 
> Looking through hrtimer.c I noticed
> 
> static void __devinit init_hrtimers_cpu(int cpu)
> 
> static int __cpuinit hrtimer_cpu_notify(struct notifier_block *self,
>                                         unsigned long action, void *hcpu)
> 
> 
> Couldn't the first be __cpuinit as well?

As the only user of init_hrtimers_cpu is __cpuinit then it is a bug
that init_hrtimers_cpu is __devinit today.

So you are correct and it must be fixed.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/