Re: [PATCH] CRIS v10: vmlinux.lds.S Fix kernel oops on boot and use common defines

[Sam Ravnborg]

On Tue, Jan 15, 2008 at 02:36:24PM +0100, Jesper Nilsson wrote:
> - Move alignment to page size of init data outside ifdef for BLK_DEV_INITRD.
>   The reservation up to page size of memory after init data was previously
>   not done if BLK_DEV_INITRD was undefined.
>   This caused a kernel oops when init memory pages were freed after startup,
>   data placed in the same page as the last init memory would also be freed
>   and reused, with disastrous results.
> 
> - Use macros for initcalls and .text sections.
> 
> - Replace hardcoded page size constant with PAGE_SIZE define.
> 
> - Change include/asm-cris/page.h to use the _AC macro to instead
>   of testing __ASSEMBLY__.

Looks good.

What about applying the same fixes/changes to v32?

It would btw. be nice to move the vmlinux.lds.S files to
arch/cris/kernel/.
Se how x86 handle build for two different bit sizes.

If this is done then cris is less awkward compared
to the other archs.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/