Re: [PATCH 2/3] x86_64: check MSR to get MMCONFIG for AMD Family10h Opteron

From: H. Peter Anvin
Date: Tue Jan 15 2008 - 10:48:21 EST


Yinghai Lu wrote:
+
+ address = 0xc0010058;
+ if (rdmsr_safe(address, &low, &high))
+ return NULL;
+

NAK. Add the symbolic MSR name to asm-x86/msr-index.h and use the symbolic name in the code, please.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/