Re: [PATCH] x86: add is_f00f_bug helper to fault_32|64.c

[H. Peter Anvin]

Kyle McMartin wrote:
> On Tue, Jan 15, 2008 at 06:48:35PM -0800, Harvey Harrison wrote:
> > +#ifdef CONFIG_X86_F00F_BUG
> > +void do_invalid_op(struct pt_regs *, unsigned long);
> > +#endif
> > +
> > +static int is_f00f_bug(struct pt_regs *regs, unsigned long address)
> > +{
> > +#ifdef CONFIG_X86_F00F_BUG
> > +	unsigned long nr;
>
> You can just put the prototype inside the function, you know...

You can also make the prototype unconditional, even if the function 
doesn't necessarily exist.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/