Re: [PATCHv2] x86: Use v8086_mode helper, trivial unification

[H. Peter Anvin]

Harvey Harrison wrote:
> On Fri, 2008-01-18 at 16:00 +0100, Ingo Molnar wrote:
> > > > +	/*
> > > > +	 * Did it hit the DOS screen memory VA from vm86 mode?
> > > > +	 */
> > > > +	if (v8086_mode(regs)) {
> > > > +		unsigned long bit = (address - 0xA0000) >> PAGE_SHIFT;
> > > > +		if (bit < 32)
> > > > +			tsk->thread.screen_bitmap |= 1 << bit;
> > > > +	}
> > this does not build on 64-bit, because screen_bitmap is 32-bit only - so 
> > i had to pull the patch. I suspect a small #ifdef section would look 
> > better here?
>
> My original patch had the ifdef, you can grab that one.

Me bad, I should have been less definite in my reply.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/