Re: [PATCH 05/26] atl1: print debug info if rrd error

[Jeff Garzik]

jacliburn@xxxxxxxxxxxxx wrote:
> From: Jay Cliburn <jacliburn@xxxxxxxxxxxxx>
>
> Add some debug dev_printks if we encounter a bad receive return descriptor.
>
> Signed-off-by: Jay Cliburn <jacliburn@xxxxxxxxxxxxx>
> ---
>  drivers/net/atlx/atl1.c |   21 ++++++++++++++++++++-
>  1 files changed, 20 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
> index 239641f..262d3ca 100644
> --- a/drivers/net/atlx/atl1.c
> +++ b/drivers/net/atlx/atl1.c
> @@ -1127,7 +1127,26 @@ static void atl1_intr_rx(struct atl1_adapter *adapter)
>  		if (likely(rrd->xsz.valid)) {	/* packet valid */
>  chk_rrd:
>  			/* check rrd status */
> -			if (likely(rrd->num_buf == 1))
> +			if (rrd->num_buf != 1) {
> +				dev_printk(KERN_DEBUG, &adapter->pdev->dev,
> +					"rx_buf_len = %d\n",
> +					adapter->rx_buffer_len);
> +				dev_printk(KERN_DEBUG, &adapter->pdev->dev,
> +					"RRD num_buf = %d\n",
> +					rrd->num_buf);
> +				dev_printk(KERN_DEBUG, &adapter->pdev->dev,
> +					"RRD pkt_len = %d\n",
> +					rrd->xsz.xsum_sz.pkt_size);
> +				dev_printk(KERN_DEBUG, &adapter->pdev->dev,
> +					"RRD pkt_flg = 0x%08X\n",
> +					rrd->pkt_flg);
> +				dev_printk(KERN_DEBUG, &adapter->pdev->dev,
> +					"RRD err_flg = 0x%08X\n",
> +					rrd->err_flg);
> +				dev_printk(KERN_DEBUG, &adapter->pdev->dev,
> +					"RRD vlan_tag = 0x%08X\n",
> +					rrd->vlan_tag);
> +			} else

look into netif_msg_*, which enables via ethtool very fine-grained 
selection of messages.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/