Re: [PATCH -mm 5/5] b43: Avoid unregistering device objects during suspend

From: Rafael J. Wysocki
Date: Fri Jan 25 2008 - 06:47:55 EST


On Friday, 25 of January 2008, Michael Buesch wrote:
> On Friday 25 January 2008 08:47:46 Pavel Machek wrote:
> > On Fri 2008-01-25 01:37:33, Rafael J. Wysocki wrote:
> > > From: Rafael J. Wysocki <rjw@xxxxxxx>
> > >
> > > Modify the b43 driver to avoid deadlocking suspend and resume,
> > > which happens as a result of attempting to unregister device objects
> > > locked by the PM core during suspend/resume cycles. Also, make it
> > > use a suspend-safe method of unregistering device object in the
> > > resume error path.
> > >
> > > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> > > Acked-by: Michael Buesch <mb@xxxxxxxxx>
> >
> > Maybe we should have global suspend_in_progress (or maybe system_state
> > == suspending?) and automatically switch to schedule_removal() while
> > it is set?
> >
>
> That would be great, from my perspective :)

Let's see how many drivers are going to need that. If there's more than a
couple, it will certainly make sense to have a global variable like this.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/