Re: [PATCH] x86: trim ram need to check if mtrr is there v2

From: H. Peter Anvin
Date: Fri Jan 25 2008 - 10:51:39 EST


Ingo Molnar wrote:
* Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:

is_cpu(INTEL) already make sure we have mtrr_if got assigned and cpu_has_mtrr.

may need to fix qemu instead...

no ...

lets not do non-sensical trimming of RAM, ok? Emit a warning but never trim all of RAM and make the system unbootable. Trimmed RAM is something that users can pester board/BIOS vendors with. Non-booting kernels is something _we_ get pestered with ;-)


*And* let's push a fix to Qemu/KVM as appropriate.

Last I checked Qemu never even turns caching on in %cr0, never mind gets the MTRRs right. If it's advertising MTRRs, this is a problem.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/