Re: [PATCH] x86: trim ram need to check if mtrr is there v3

From: Jeremy Fitzhardinge
Date: Fri Jan 25 2008 - 13:59:23 EST


Ingo Molnar wrote:
* Yinghai Lu <Yinghai.Lu@xxxxxxx> wrote:

[PATCH] x86: trim ram need to check if mtrr is there v3

H. Peter Anvin wrote:
Looks like the code doesn't check that the CPU *has* MTRRs...
so more strict check if mtrr is there really.
bail out if mtrr all blank when qemu cpu model is used

and check if is AMD as early
also remove 4G less check, according to hpa.

thanks, applied. Shouldnt we put in an exception for when there is MTRR support, but they dont cover anything. Still emit a warning - but booting up real slow is still better than losing all of RAM and crashing ...

i also updated the messages, they now go like this:

WARNING: strange, CPU MTRRs all blank?

and:

WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 45MB of RAM.

Though I don't see this form of message; have you pushed your changes out to the public x86.git#mm tree?

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/