Re: [PATCH 183/196] driver core: fix build with SYSFS=n

[Greg KH]

On Fri, Jan 25, 2008 at 11:25:30PM +0100, Ingo Molnar wrote:
> 
> * Greg Kroah-Hartman <gregkh@xxxxxxx> wrote:
> 
> > From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> > 
> > When SYSFS=n and MODULES=y, build ends with:
> > 
> > linux-2.6.24-rc6-mm1/drivers/base/module.c: In function 'module_add_driver':
> > linux-2.6.24-rc6-mm1/drivers/base/module.c:49: error: 'module_kset' undeclared (first use in this function)
> > make[3]: *** [drivers/base/module.o] Error 1
> 
> _PLEASE_ fold such fixes into the patch that introduces the build bugs, 
> prior sending your git trees upstream! (just like Andrew does it with 
> all patches that come via -mm)

For most of these issues I do merge them together.

However, for some odd kernel configurations, like this one, I didn't, my
appologies.  I'll try to be more careful in the future.

> Changes like this (and it now leaked into Linus' tree as well) kill 
> bisectability.

The odds that a "normal" person has sysfs turned off and modules
enabled, trying to bisect things, is pretty slim :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/