Re: [PATCH 085/196] kset: convert s390 ipl.c to use kset_create

[Heiko Carstens]

On Fri, Jan 25, 2008 at 09:48:58AM -0800, Greg KH wrote:
> On Fri, Jan 25, 2008 at 01:20:53PM +0100, Heiko Carstens wrote:
> > On Thu, Jan 24, 2008 at 11:31:54PM -0800, Greg Kroah-Hartman wrote:
> > > Dynamically create the kset instead of declaring it statically.
> > > This makes the kobject attributes now work properly that I broke in the
> > > previous patch.
> > 
> > Could you please merge this and the previous patch before it goes
> > upstream? Having an intermediate state where things are broken
> > will cause pain and additional work in case of bisecting.
> 
> It will not cause a build error (see the previous patch for details.)
> The sysfs files will not properly show the correct data, that is all.
>
> The odds that you will hit this in a 'git bisect' is VERY low, and the
> previous patch states that the files are now broken, so there should not
> be any confusion regarding any user that might run across this.

The odds are very low, as long as not more patch sets come up which
introduce intermediate broken kernels.
What exactly is the advantage of breaking the kernel with patch 1 and
then fix it again with patch 2 instead of doing the straight forward
conversions all with one patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/