Re: [PATCH] defer printks in irqs

From: Andrew Morton
Date: Sun Jan 27 2008 - 01:04:58 EST


> On Thu, 24 Jan 2008 15:23:03 -0800 Tim Bird <tim.bird@xxxxxxxxxxx> wrote:
> Peter Zijlstra wrote:
> > I suspect these features reduce the chance a crash messages makes it out
> > onto the console, but fail to spot any of the copious text mention this
> > critical issue.
>
> Anything not in interrupts would not be deferred.
> The following code is meant to avoid deferring in oops as well.
> I'm not sure if that covers all crash cases or not.
> If you know of other cases, and ways to detect them, please advise.
>

Yes, using oops_in_progress seems an appropriate fix for that.

I assume that another downside is that printk-from-interrupt will now get
jumbled up with an interrupted pritk-from-non-interrupt.

Please use checkpatch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/