Re: [PATCH 17/52] [microblaze] checksum support

[Geert Uytterhoeven]

On Thu, 24 Jan 2008, monstr@xxxxxxxxx wrote:
> From: Michal Simek <monstr@xxxxxxxxx>
> 
> 
> Signed-off-by: Michal Simek <monstr@xxxxxxxxx>
> ---
>  arch/microblaze/lib/checksum.c    |  159 +++++++++++++++++++++++++++++++++++++
>  include/asm-microblaze/checksum.h |  101 +++++++++++++++++++++++
>  2 files changed, 260 insertions(+), 0 deletions(-)
>  create mode 100644 arch/microblaze/lib/checksum.c
>  create mode 100644 include/asm-microblaze/checksum.h
> 
> diff --git a/arch/microblaze/lib/checksum.c b/arch/microblaze/lib/checksum.c
> new file mode 100644
> index 0000000..21a6830
> --- /dev/null
> +++ b/arch/microblaze/lib/checksum.c
> @@ -0,0 +1,159 @@
> +/*
> + * INET		An implementation of the TCP/IP protocol suite for the LINUX
> + *		operating system.  INET is implemented using the  BSD Socket
> + *		interface as the means of communication with the user level.
> + *
> + *		IP/TCP/UDP checksumming routines
> + *
> + * Authors:	Jorge Cwik, <jorge@xxxxxxxxxxxxxxxxx>
> + *		Arnt Gulbrandsen, <agulbra@xxxxxxxxxxx>
> + *		Tom May, <ftom@xxxxxxxxxx>
> + *		Andreas Schwab, <schwab@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> + *		Lots of code moved from tcp.c and ip.c; see those files
> + *		for more names.
> + *
> + * 03/02/96	Jes Sorensen, Andreas Schwab, Roman Hodek:
> + *		Fixed some nasty bugs, causing some horrible crashes.
> + *		A: At some points, the sum (%0) was used as
> + *		length-counter instead of the length counter
> + *		(%1). Thanks to Roman Hodek for pointing this out.
> + *		B: GCC seems to mess up if one uses too many
> + *		data-registers to hold input values and one tries to
> + *		specify d0 and d1 as scratch registers. Letting gcc choose these
> + *      registers itself solves the problem.
> + *
> + *		This program is free software; you can redistribute it and/or
> + *		modify it under the terms of the GNU General Public License
> + *		as published by the Free Software Foundation; either version
> + *		2 of the License, or (at your option) any later version.
> + */
> +
> +/* Revised by Kenneth Albanowski for m68knommu. Basic problem: unaligned access
> + kills, so most of the assembly has to go. */

So basically this is a copy of arch/m68knommu/lib/checksum.c, with some
checkpatch.pl fixes but without the sparse fixes?
Furthermore, it's just plain C, so maybe we need a common one that can
be shared by multiple archs?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/