Re: [PATCH -mm 2/2] PWM LED driver

[Haavard Skinnemoen]

On Mon, 28 Jan 2008 01:29:32 -0800
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> > -	if (i > 0) {
> > -		for (i = i - 1; i >= 0; i--) {
> > -			led_classdev_unregister(&leds[i].cdev);
> > -			pwm_channel_free(&leds[i].pwmc);
> > -		}
> > +	while (i-- > 0) {
> > +		led_classdev_unregister(&leds[i].cdev);
> > +		pwm_channel_free(&leds[i].pwmc);
> >  	}  
> 
> Looks OK, although I'd say that `while (--i >= 0)' is more idiomatic -
> predecrement, postincrement and all that?

Maybe. while (i-- > 0) has the advantage that it will work even if i is
unsigned though...

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/