Re: [RFC] Per-thread getrusage

[Pavel Emelyanov]

Andrew Morton wrote:
> On Mon, 28 Jan 2008 13:43:02 -0700
> ebiederm@xxxxxxxxxxxx (Eric W. Biederman) wrote:
> 
>> Pavel Emelyanov <xemul@xxxxxxxxxx> writes:
>>>> ...
>>>> +asmlinkage long sys_thread_getrusage(int tid, struct rusage __user *ru)
>>>> +{
>>>> +	struct task_struct *tsk;
>>>> +	tsk = find_task_by_pid(tid);
>>>> +	return getrusage(tsk, RUSAGE_THREAD, ru);
>>>> +}
>>> Well, the find_task_by_pid() is really wrong here.
>> And find_task_by_pid should probably just be removed.
> 
> That's what I was thinking.

find_task_by_pid and find_pid are to be removed, but this task
heavily depends on others.

E.g. to drop the find_pid() we need to kill the kill_proc() 
function, which in turn depends on turning the usbatm, nfs and 
lockd code into kthread API. We're currently working on this.

>> No need to provide function with the gun firmly pointed at our feet....
> 
> It still has a disturbingly large number of callers.

Yes, but unfortunately simple conversion from find_xxx_pid into
find_xxx_vpid is not possible - each case is special.

Thanks,
Pavel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/