Re: [PATCH 3/7] X86: Fix trailing statements should be on next line

[Stefan Richter]

Willy Tarreau wrote:
> Hi Paolo,
> 
> On Tue, Jan 29, 2008 at 12:07:44AM +0100, Paolo Ciarrocchi wrote:
>> Fix trailing statements should be on next line
> 
>> -if ( partial_status & SW_C3 )          printk("SW: condition bit 3\n");
...
>> +if ( partial_status & SW_Backward )
>> +printk("SW: backward compatibility\n");
...
> 
> Well, IMHO, the code was more readable and checkable in the initial
> version. I think this is one example of exceptions where code appearance
> is more important than style correctness.

Besides, the proposed style "fix" itself violates CodingStyle in at
least two obvious ways.
-- 
Stefan Richter
-=====-==--- ---= ===-=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/