Re: ndiswrapper and GPL-only symbols redux

From: Andi Kleen
Date: Wed Jan 30 2008 - 01:03:32 EST


Pavel Roskin <proski@xxxxxxx> writes:
> */
> @@ -162,6 +163,7 @@ const char *print_tainted(void)
> if (tainted) {
> snprintf(buf, sizeof(buf), "Tainted: %c%c%c%c%c%c%c%c",
> tainted & TAINT_PROPRIETARY_MODULE ? 'P' : 'G',
> + tainted & TAINT_BLOB_WRAPPER ? 'W' : ' ',


Are you sure you don't need to add a new '%c' to the format string too?
I think gcc should have warned.

-Andi

> tainted & TAINT_FORCED_MODULE ? 'F' : ' ',
> tainted & TAINT_UNSAFE_SMP ? 'S' : ' ',
> tainted & TAINT_FORCED_RMMOD ? 'R' : ' ',
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/