Re: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory

[Jiri Slaby]

On 01/30/2008 01:39 PM, Robin Getz wrote:
> On Wed 30 Jan 2008 06:00, Jiri Slaby pondered:
> > On 01/30/2008 11:36 AM, Bryan Wu wrote:
> > > From: Mike Frysinger <michael.frysinger@xxxxxxxxxx>
> > >
> > > initial char driver for otp memory
> > > (only read supported atm ... needs real examples/docs for write support)
> > >
> > > Signed-off-by: Mike Frysinger <michael.frysinger@xxxxxxxxxx>
> > > Signed-off-by: Bryan Wu <bryan.wu@xxxxxxxxxx>
>
> > > +	bfin_otp_class = class_create(THIS_MODULE, "otp");
> > > +	device_create(bfin_otp_class, NULL, bfin_otp_dev_node, "otp");
> > Anyway, wouldn't be easier/better to use misc.c functionality here 
> > (misc_register() et al.)?
>
> OTP (one time programmable) memory are not registers, they are small blocks 
> (8k bytes) of non violate on chip memory, for storing things that you don't 
> want other people to look at via a PCB level probe. (like keys), or things 
> that are just helpful - like MAC addresses.

Sorry, misc_register() allows you to get rid of the chrdev initialization 
including class creation. Maybe I'm not understanding what you are trying to 
explain me?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/