Re: [PATCH 2/2] Char: applicom, use pci_match_id

[Andrew Morton]

On Wed, 30 Jan 2008 12:13:15 +0100
Jiri Slaby <jirislaby@xxxxxxxxx> wrote:

> +		if (!pci_match_id(applicom_pci_tbl, dev));
>  			continue;


The patch was carelessly prepared, was not runtine-tested and was not
passed through checkpatch, which detects this error.  Please fix these
things, permanently.

It's hard to overemphasise how out-of-balance the economics are here.  You
saved maybe thirty person-seconds by skipping the review and checkpatch
steps.  But the cost (if this bug had gone into mainline) would be many
many thousands times higher than this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/