Re: [PATCH 3/4] IB: add dmabarrier to ib_umem_get() prototype

[Roland Dreier]

 > diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c
 > index 4e3128f..5b00408 100644
 > --- a/drivers/infiniband/core/umem.c
 > +++ b/drivers/infiniband/core/umem.c
 > @@ -74,7 +74,7 @@ static void __ib_umem_release(struct ib_device *dev, struct ib_umem *umem, int d
 >   * @access: IB_ACCESS_xxx flags for memory being pinned
 >   */
 >  struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
 > -			    size_t size, int access)
 > +			    size_t size, int access, int dmabarrier)
 >  {
 >  	struct ib_umem *umem;
 >  	struct page **page_list;

Two problems here, one major: this doesn't actually do anything with
the dmabarrier parameter, and one minor: it also doesn't add any
documentation for the parameter to the comment before the function.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/