Re: [PATCH] latencytop: Change Kconfig dependency.

[Sam Ravnborg]

On Fri, Feb 01, 2008 at 02:06:36PM +0100, Heiko Carstens wrote:
> From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> 
> Change latencytop Kconfig entry so it doesn't list the archictectures
> that support it. Instead introduce HAVE_LATENCY_SUPPORT which any
> architecture can set. Should reduce patch conflicts.
> 
> Cc: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxx>
> Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> Cc: Holger Wolf <wolf@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> ---
> 
> If ok, should this go in via the x86 tree?
> 
>  arch/x86/Kconfig  |    3 +++
>  lib/Kconfig.debug |    2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> Index: linux-2.6/arch/x86/Kconfig
> ===================================================================
> --- linux-2.6.orig/arch/x86/Kconfig
> +++ linux-2.6/arch/x86/Kconfig
> @@ -44,6 +44,9 @@ config LOCKDEP_SUPPORT
>  config STACKTRACE_SUPPORT
>  	def_bool y
>  
> +config HAVE_LATENCYTOP_SUPPORT
> +	def_bool y
> +
No.
Please do:
 config X86
+	select HAVE_LATENCYTOP_SUPPORT

Yes - this is a valid use of select.

See Documentation/kbuild/kconfig-language.txt

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/