Re: [2.6 patch] x86: allow 64bit setting in Kconfig

[Ingo Molnar]

* Adrian Bunk <bunk@xxxxxxxxxx> wrote:

>  # Select 32 or 64 bit
>  config 64BIT
> -	bool "64-bit kernel" if ARCH = "x86"
> +	bool "64-bit kernel"
>  	default ARCH = "x86_64"

NACK. You have just broken:

    make ARCH=i386 randconfig

on a 64-bit box that has a 32-bit .config in its kernel directory.

The randconfig/allyesconfig/allnoconfig variants override whatever is in 
the current .config. Making the result depend on whatever is in the 
.config at the moment is fundamentally wrong.

"oldconfig" on the other hand has correct sensitivity to the existing 
.config - and that always worked correctly. So if you pop a 32-bit or a 
64-bit .config into a kernel tree, that will be listened to, no matter 
whether you are on a 32-bit or on a 64-bit host.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/