Re: [PATCH] Use on-board instead of built-in in config options

[Bartlomiej Zolnierkiewicz]

On Sunday 27 January 2008, Frans Pop wrote:
> On Saturday 26 January 2008, Bartlomiej Zolnierkiewicz wrote:
> > On Saturday 26 January 2008, Jan Engelhardt wrote:
> > > On Jan 26 2008 21:31, Frans Pop wrote:
> > > >>  config BLK_DEV_IDE_PMAC
> > > >> -       bool "Builtin PowerMac IDE support"
> > > >> +       tristate "Builtin PowerMac IDE support"
> >
> > this change is no-op at the moment because the next Kconfig line is:
> >
> > 	depends on PPC_PMAC && IDE=y && BLK_DEV_IDE=y
> >
> > [ PPC-specific IDE host drivers are still a special case because they are
> >   using ppc_ide_md architecture hooks instead of doing proper host driver
> >   initialization sequence - to be fixed after adding warm-plug support...
> > ]
> >
> > > >This does not seem to make sense: if the option is now tristate, it is
> > > > no longer "Builtin", so probably s/Builtin // in the description.
> > >
> > > Or something like s/Builtin/Onboard/;
> 
> I did not even consider that meaning of built-in, but that does seem more 
> descriptive.
> 
> > Please send a patch.
> 
> Of course :-)
> 
> ---
> From: Frans Pop <elendil@xxxxxxxxx>
> 
> To avoid confusion between 'built-in' drivers and 'on-board'
> controllers, consistently use the term 'on-board' for controllers.
> 
> Minor line-wrapping improvements in descriptions for config options.
> 
> Signed-off-by: Frans Pop <elendil@xxxxxxxxx>

applied, thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/