Re: [PATCH 6 of 7] x86: move pud/pgd functions into common asm/pgalloc.h

From: Jeremy Fitzhardinge
Date: Sat Feb 02 2008 - 05:21:45 EST


Ingo Molnar wrote:
* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

Common definitions for 4-level pagetable functions.

Signed-off-by: Jeremy Fitzhardinge <jeremy@xxxxxxxxxxxxx>
---
arch/x86/mm/pgtable.c | 7 ++++++
include/asm-x86/pgalloc.h | 46 ++++++++++++++++++++++++++++++++++++------
include/asm-x86/pgalloc_32.h | 24 ---------------------
include/asm-x86/pgalloc_64.h | 32 -----------------------------
4 files changed, 47 insertions(+), 62 deletions(-)

random-qa found an early bootup hang on 32-bit (config attached).

The config you sent was 64-bit.

i bisected it down to this patch of yours. It's a bit large so it's not obvious what is happening. Could you please keep patches that do functional changes smaller?

Will do, though this one is more or less pure code motion. But I can make it actual pure code motion with a separate merge patch.

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/