Re: Section mismatch warning patch - microcode.c

From: Sam Ravnborg
Date: Sat Feb 02 2008 - 09:02:40 EST


On Sat, Feb 02, 2008 at 04:39:02PM +0800, Peter Teoh wrote:
> The following errors during compilation is corrected by the following
> patch (against the latest linus tree):
>
> WARNING: arch/x86/kernel/microcode.o(.exit.text+0x6): Section mismatch
> in reference from the function cleanup_module() to the variable
> .cpuinit.data:mc_cpu_notifier

I have missed this one when I did my last fix to that file.
But your patch is not good.

Annotating the microcode_exit() function with __init will
cause the kernel to drop the code long before we need it.

I will look into this later and post a fix for the warning.

Sam

> @@ -831,7 +831,7 @@ static int __init microcode_init (void)
> return 0;
> }
>
> -static void __exit microcode_exit (void)
> +static void __init microcode_exit (void)
> {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/