Re: [patch] pci: pci_enable_device_bars() fix

From: Jeff Garzik
Date: Sat Feb 02 2008 - 15:48:56 EST


Ingo Molnar wrote:
so please tell me Jeff. If Greg, who is the super-maintainer of your code area, and who deals with your code every day and changes it every minute and hour, simply did not Cc: the SCSI list - how am i, a largely outside party in this matter, supposed to notice that 3 maintainers and 3 mailing lists in the Cc: were somehow not enough and that i was supposed to grow the already sizable Cc: list even more?

Because, regardless of the situation, it's both common courtesy and wise practice to CC relevant driver maintainers, when you touch a driver.

And it's just common sense: Greg simply does not know the intimate details of every PCI driver. Nor do I. Nor you.

In the case of lpfc here, we have an active driver maintainer, and an up-to-date MAINTAINERS entry. Even if you are too slack to read MAINTAINERS, 'git log' would have given you the same info.

Don't pretend there is some benefit here to ignoring the people that best know the driver. I don't buy that; it simply makes no engineering sense whatsoever.

Jeff


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/