Re: [RFC] x86: setup code_bytes - use mask to restrict it's size

[H. Peter Anvin]

Cyrill Gorcunov wrote:
> This patch strips off 8 bytes from text section. Not a really
> big advantage (especially for __init section). It seems 8192
> bytes of disassembled code is rare used anyway.
>
> before:
> 	text    data     bss     dec     hex filename
> 	9900     176      20   10096    2770 arch/x86/kernel/traps_64.o.old
> after:
> 	text    data     bss     dec     hex filename
> 	9892     176      20   10088    2768 arch/x86/kernel/traps_64.o
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
> ---
>
> If there is no benefit at all - just drop the patch.
> Any comments are welcome ;)

I don't think this is the behaviour we want (wrapping around); worse, if 
people enter a larger power of two they will get zero.

So NAK on this patch, IMO.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/