Re: [PATCH 1/2] Split list.h and move rcu-protected lists into rculist.h

From: Franck Bui-Huu
Date: Sun Feb 03 2008 - 03:46:04 EST


Andrew Morton wrote:
> On Sat, 02 Feb 2008 14:32:41 +0100 Franck Bui-Huu <vagabon.xyz@xxxxxxxxx> wrote:
>> Do you think it's better ?
>
> Could. I'd suggest that you redo the header-file split patch around the
> 2.6.25-rc1 timeframe, test it carefully then let's get it in then.
>

Does the mm tree also have a calm down period during release candidates ?

I have modified the patchset so now if rcu helpers are used from
rculist.h then fine otherwise gcc warns you that you're using the
helpers from list.h like this:

init/foo.c:13: warning: ‘__deprecated_list_add_rcu’ is deprecated (declared at include/linux/rculist.h:76)

But the build process doesn't fail anymore.

For that I added some ugly hacks in list.h and rculist.h but they
definitively should be removed for mainline inclusion. I'm sending them
in response to this email.

If we include this now, then people can have a chance to notice that
rculist.h exists and fix their stuffs until 2.6.25 release
candidates but I'll redo the patchset and give it some test around the
2.6.25-rc1 timeframe anyway.

Franck




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/