Re: [rfc] direct IO submission and completion scalability issues

[Pekka Enberg]

Hi Nick,

On Feb 3, 2008 11:52 AM, Nick Piggin <npiggin@xxxxxxx> wrote:
> +asmlinkage void smp_call_function_fast_interrupt(void)
> +{

[snip]

> +       while (!list_empty(&list)) {
> +               struct call_single_data *data;
> +
> +               data = list_entry(list.next, struct call_single_data, list);
> +               list_del(&data->list);
> +
> +               data->func(data->info);
> +               if (data->wait) {
> +                       smp_mb();
> +                       data->wait = 0;

Why do we need smp_mb() here (maybe add a comment to keep
Andrew/checkpatch happy)?

                        Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/