Re: [patch 1/4] AVR32: cleanup - use _AC macro to define PAGE_SIZE

From: Haavard Skinnemoen
Date: Sun Feb 03 2008 - 08:26:24 EST


[removed bogus @atmel.co address from Cc]

On Sun, 03 Feb 2008 14:22:18 +0300
Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:

> Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>

Applied, thanks.

I found myself having to grep through include/linux to figure out what
this _AC macro was really all about, so I added this to the description:

PAGE_SIZE is used both from assembly and C code. We want to have type
specifiers when using it from C, but this will make the assembler
confused, so we need to make it conditional.

This is exactly what the _AC macro is for, so using it allows us to
get rid of a few lines of cpp noise.

My first thought was "Autoconf", and it sent shivers down my spine ;-)

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/