Re: LPFC compilation error in 2.6.24-git12/git13

From: Jeff Garzik
Date: Sun Feb 03 2008 - 12:35:37 EST


Peter Teoh wrote:
--- lpfc_init.c.old 2008-02-03 19:26:20.000000000 +0800
+++ drivers/scsi/lpfc/lpfc_init.c 2008-02-03 19:26:42.000000000 +0800
@@ -1894,7 +1894,7 @@ lpfc_pci_probe_one(struct pci_dev *pdev,
uint16_t iotag;
int bars = pci_select_bars(pdev, IORESOURCE_MEM);

- if (pci_enable_device_bars(pdev, bars))
+ if (pci_enable_device_io(pdev))
goto out;


As already discussed and pointed out on LKML and linux-scsi, this is the wrong change. Look at the line above the one you changed -- we want mem not io.

Jeff


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/