Re: [PATCH 1/9] firewire: log GUID of new devices

[Stefan Richter]

I wrote:
> -	else
> -		fw_notify("created new fw device %s "
> -			  "(%d config rom retries, S%d00)\n",
> -			  device->device.bus_id, device->config_rom_retries,
> -			  1 << device->max_speed);
> +	} else {
> +		if (device->config_rom_retries)
> +			fw_notify("created device %s: GUID %08x%08x, S%d00, "
> +				  "%d config ROM retries\n",
> +				  device->device.bus_id,
> +				  device->config_rom[3], device->config_rom[4],
> +				  1 << device->max_speed,
> +				  device->config_rom_retries);

Still to do:  If the ROM reading failed, log how it failed and what was
read up until the failure.
-- 
Stefan Richter
-=====-==--- --=- --=--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/