Re: 2.6.24-git4+ regression

From: Ingo Molnar
Date: Mon Feb 04 2008 - 07:01:57 EST



* Lukas Hejtmanek <xhejtman@xxxxxxxxxxx> wrote:

> but in such a case, kernel 2.6.24-git13 does oops at startup in
> sched_slice.

could you tell me more about this oops? You booted unmodified, latest
-git and it oopsed in sched_slice()? The patch below should work around
any oopses in sched_slice(). [but this is really a 'must not happen'
scenario - so a just-for-testing patch]

Ingo

Index: linux-x86.q/kernel/sched_fair.c
===================================================================
--- linux-x86.q.orig/kernel/sched_fair.c
+++ linux-x86.q/kernel/sched_fair.c
@@ -268,7 +268,8 @@ static u64 sched_slice(struct cfs_rq *cf
u64 slice = __sched_period(cfs_rq->nr_running);

slice *= se->load.weight;
- do_div(slice, cfs_rq->load.weight);
+ if (cfs_rq->load.weight)
+ do_div(slice, cfs_rq->load.weight);

return slice;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/