Re: [PATCH] Whine about suspicious return values from module's->init() hook

[Andrew Morton]

On Tue, 5 Feb 2008 14:43:31 +1100 Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

> On Tuesday 05 February 2008 02:42:15 Alexey Dobriyan wrote:
> > One head-scratching session could be noticeably shorter with this patch...
> >
> > Signed-off-by: Alexey Dobriyan <adobriyan@xxxxx>
> 
> If we want to prevent > 0 returns, let's just BUG_ON().
> 

That risks killing previously-working setups.  WARN_ON is sufficient.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/