Re: {2.6.22.y} quicklists must keep even off node pages on the quicklists until the TLB flush has been completed.

[Oliver Pinter]

I use this, without errors ... but the machine is i386 desktop

On Feb 6, 2008 7:02 AM, Dhaval Giani <dhaval@xxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, Feb 05, 2008 at 10:06:02PM +0100, Oliver Pinter wrote:
> > it is already im queue for 2.6.23,
> >
> > ----8<-----
> > >From stable-bounces@xxxxxxxxxxxxxxxx Sat Dec 22 14:04:08 2007
> > From: Christoph Lameter <clameter@xxxxxxx>
> > Date: Sat, 22 Dec 2007 14:03:23 -0800
> > Subject: quicklists: do not release off node pages early
> > To: torvalds@xxxxxxxxxxxxxxxxxxxx
> > Cc: stable@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx,
> > dhaval@xxxxxxxxxxxxxxxxxx, clameter@xxxxxxx
> > Message-ID: <200712222203.lBMM3Nsk021922@xxxxxxxxxxxxxxxxxxxxxxxxxx>
> >
> >
> > From: Christoph Lameter <clameter@xxxxxxx>
> >
> > patch ed367fc3a7349b17354c7acef551533337764859 in mainline.
> >
> > quicklists must keep even off node pages on the quicklists until the TLB
> > flush has been completed.
> >
> > Signed-off-by: Christoph Lameter <clameter@xxxxxxx>
> > Cc: Dhaval Giani <dhaval@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> >
> > ---
> >  include/linux/quicklist.h |    8 --------
> >  1 file changed, 8 deletions(-)
> >
> > --- a/include/linux/quicklist.h
> > +++ b/include/linux/quicklist.h
> > @@ -56,14 +56,6 @@ static inline void __quicklist_free(int
> >       struct page *page)
> >  {
> >       struct quicklist *q;
> > -     int nid = page_to_nid(page);
> > -
> > -     if (unlikely(nid != numa_node_id())) {
> > -             if (dtor)
> > -                     dtor(p);
> > -             __free_page(page);
> > -             return;
> > -     }
> >
> >       q = &get_cpu_var(quicklist)[nr];
> >       *(void **)p = q->page;
> >
> > ---->8------
> > Tested-by: Oliver Pinter <oliver.pntr@xxxxxxxxx> (on i386)
> >
>
> Christoph,
>
> Is this one also supposed to be backported?
>
> --
> regards,
> Dhaval
>



-- 
Thanks,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/