Re: [Kgdb-bugreport] [PATCH 4/5] KGDB-8250: refactor configuration

[Sergei Shtylyov]

Hello.

Jan Kiszka wrote:

> > > Sorry, previous version was missing some __init[data] attributes which
> > > were dropped in an intermediate stage. Here comes an updated patch:

> > > <---snip--->

> > > This major refactoring of the quite complex kgdb8250 configuration does
> > > the following:

> > > - ensures that static configurations according to SERIAL_PORT_DFNS are
> > >   always loaded first
> > > - tries to pull more accurate configuration via serial8250_get_port_def
> > >   if simple-config is used
> > > - detects empty/invalid simple-configs
> > > - enforces KGDB_PORT_NUM <= SERIAL_8250_NR_UARTS at kconfig level
> > > - removes kgdb8250_add_port and its hook in serial_core (calling
> > >   serial8250_get_port_def in demand should provide us the same
> > >   information)

> >   You left powerpc-lite.patch broken with this change as it has
> > multiple calls to kgdb8250_add_port()...

> I see. But I wonder if there ever was a real need for these hooks (in
> 2.4 times?): If I look at bamboo_early_serial_map() e.g., I find it
> calling into early_serial_setup() which fills serial8250_ports[] - and
> that content is now retrieved via serial8250_get_port_def() when we
> parse the runtime or build-time provided parameters (port number &
> baudrate).

   Of course. But now the kgdb8250_add_port() calls need to be removed.

> > > Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxx>

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/