Re: [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc()

From: Sergei Shtylyov
Date: Wed Feb 06 2008 - 13:07:34 EST


Bartlomiej Zolnierkiewicz wrote:

Same BUG_ON() is present inside ide_set_handler().

There is no BUG_ON there -- __ide_set_handler() has a check for the same condition and a printk(KERN_CRIT)... myabe it should be replaced with BUG_ON()...

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>

Acked-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/