Re: [PATCH 24/27] NFS: Use local caching [try #2]

[David Howells]

Chuck Lever <chuck.lever@xxxxxxxxxx> wrote:

> > @@ -95,12 +100,25 @@ struct nfs_server {
> >  	unsigned int		acdirmin;
> >  	unsigned int		acdirmax;
> >  	unsigned int		namelen;
> > +	unsigned int		options;	/* extra options enabled by mount */
> > +#define NFS_OPTION_FSCACHE	0x00000001	/* - local caching enabled */
> 
> Why did you choose to create a new field for this rather than setting up a new
> NFS_MNT flag?  The new in-kernel NFS mount option parser uses the NFS_MNT
> flags too.

There aren't any NFS_MNT flags, so I presume you mean NFS_MOUNT flags.  As I
understood Trond, it's not permitted to add new such flags except in really
special circumstances as these are part of the mount syscall interface.  I
took this to mean that I should record the option elsewhere than in
server->flags.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/