Re: [PATCH] Change pci_raw_ops to pci_raw_read/write

[Tony Camuso]

Arjan van de Ven wrote:
> On Thu, 07 Feb 2008 10:54:05 -0500
> Tony Camuso <tcamuso@xxxxxxxxxx> wrote:
>
> > Matthew,
> >
> > Perhaps I missed it, but did you address Yinghai's concerns?
> >
> > Yinghai Lu wrote:
> > > On Jan 28, 2008 7:03 PM, Matthew Wilcox <matthew@xxxxxx> wrote:
> > > > -int pci_conf1_write(unsigned int seg, unsigned int bus,
> > > > +static int pci_conf1_write(unsigned int seg, unsigned int bus,
> > > >                            unsigned int devfn, int reg, int len,
> > > > u32 value)
> > > any reason to change pci_conf1_read/write to static?
>
> nothing should use these directly. So static is the right answer ;)

Agreed. Thanks, Arjan.

Matthew,
What about the ATA_RAM addition to Kconfig? Was it accidental,
or intended? If intended, how is it related?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/