Re: [PATCH 1/2] kprobes: Introduce kprobe_handle_fault()

From: Masami Hiramatsu
Date: Thu Feb 07 2008 - 14:13:42 EST


Harvey Harrison wrote:
> Use a central kprobe_handle_fault() inline in kprobes.h to remove
> all of the arch-dependant, practically identical implementations in
> avr32, ia64, powerpc, s390, sparc64, and x86.
>
> avr32 was the only arch without the preempt_disable/enable pair
> in its notify_page_fault implementation.
>
> This uncovered a possible bug in the s390 version as that purely
> copied the x86 version unconditionally passing 14 as the trapnr
> rather than the error_code parameter. s390 is changed to pass
> error_code in this patch.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>

Tested on i386/x86-64.

Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@xxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/