[PATCH 2.5/3] palm_bk3710: port initialization/probing bugfix
From: Bartlomiej Zolnierkiewicz
Date: Thu Feb 07 2008 - 15:38:51 EST
Probe port _after_ it is fully initialized.
Cc: Anton Salnikov <asalnikov@xxxxxxxxxxxxx>
Cc: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
---
drivers/ide/arm/palm_bk3710.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
Index: b/drivers/ide/arm/palm_bk3710.c
===================================================================
--- a/drivers/ide/arm/palm_bk3710.c
+++ b/drivers/ide/arm/palm_bk3710.c
@@ -370,13 +370,6 @@ static int __devinit palm_bk3710_probe(s
ide_init_port_hw(hwif, &hw);
hwif->quirkproc = NULL;
- idx[0] = i;
-
- ide_device_add(idx, NULL);
-
- if (!hwif->present)
- goto out;
-
hwif->set_pio_mode = &palm_bk3710_set_pio_mode;
hwif->set_dma_mode = &palm_bk3710_set_dma_mode;
hwif->mmio = 1;
@@ -390,6 +383,13 @@ static int __devinit palm_bk3710_probe(s
ide_setup_dma(hwif, mem->start);
+ idx[0] = i;
+
+ ide_device_add(idx, NULL);
+
+ if (!hwif->present)
+ goto out;
+
return 0;
out:
printk(KERN_WARNING "Palm Chip BK3710 IDE Register Fail\n");
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/