Re: [git pull] Input updates for 2.6.25-rc0

[Andrew Morton]

On Thu, 7 Feb 2008 15:05:57 -0500
Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:

> On Tue, Feb 05, 2008 at 10:32:42PM -0800, Andrew Morton wrote:
> > 
> > Looks OK.  Minorish things from a quick scan:
> > 
> 
> *ping*
> 
> Linus,
> 
> Do you want me to redo the pull or is it still acceptable as is?
> I am hesitant touching the tree after sending a pull request...
> 

That's probably me being a pain in the ass and actually looking at the pull
requests.  Sorry, I really should look at these things as they go into
people's trees, not as they attempt to come out of them.  I'll do better.

Although that's not an option with some of the stealth merges we're seeing
lately..

I'd assume that by now you can apply whatever touchups are needed then
resend the pull request.



btw:

drivers/input/touchscreen/ads7846.c: fix uninitialized var warning

From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

drivers/input/touchscreen/ads7846.c: In function 'ads7846_read12_ser':
drivers/input/touchscreen/ads7846.c:216: warning: 'sample' may be used uninitialized in this function

Cc: Dmitry Torokhov <dtor@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 drivers/input/touchscreen/ads7846.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/input/touchscreen/ads7846.c~drivers-input-touchscreen-ads7846c-fix-uninitialized-var-warning drivers/input/touchscreen/ads7846.c
--- a/drivers/input/touchscreen/ads7846.c~drivers-input-touchscreen-ads7846c-fix-uninitialized-var-warning
+++ a/drivers/input/touchscreen/ads7846.c
@@ -213,7 +213,7 @@ static int ads7846_read12_ser(struct dev
 	struct ads7846		*ts = dev_get_drvdata(dev);
 	struct ser_req		*req = kzalloc(sizeof *req, GFP_KERNEL);
 	int			status;
-	int			sample;
+	int			uninitialized_var(sample);
 	int			use_internal;
 
 	if (!req)
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/