Re: [PATCH] input: driver for USB VoIP phones with CM109 chipset

[Dmitry Torokhov]

Hi Alfred,

On Thu, Feb 07, 2008 at 07:38:10PM +0100, Alfred E. Heggestad wrote:
> From: Alfred E. Heggestad <aeh@xxxxxx>
>
> This driver adds support for USB VoIP phones using the CM109 chipset,
> such as Komunikate KIP-1000 and Genius G-talk. Keypad is scanned and
> events are reported to the input subsystem. The buzzer can be activated
> by sending SND_TONE or SND_BELL to the input device. The phone keymap
> can be selected in run-time by using the "phone" module parameter.
> The driver has been tested with linux 2.6.24 on i386, and also tested
> to build cleanly on AMD64.
> More testing and code review is welcome..
>

For a long time I was sitting on the patch not sure what to do about
the pound key, but I think we need to allocate separate keycodes for
remote controls and phones that work regardless of users keymap.

Another item is keymap for different devices - the best way to handle
it I think it to implement getkeycodes and setkeycodes methods for
the input device and have alternative keymaps loaded from userspace
instead of adding module parameters.

The rest of the driver looks great and I am sorry I was ignoring it
for so long.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/