Re: - typhoon-section-fix.patch removed from -mm tree

[Andrew Morton]

On Thu, 7 Feb 2008 23:36:01 +0100
Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:

> On Thu, Feb 07, 2008 at 02:30:08PM -0800, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> > 
> > The patch titled
> >      typhoon section fix
> > has been removed from the -mm tree.  Its filename was
> >      typhoon-section-fix.patch
> > 
> > This patch was dropped because I just remembered __devexitconst :(
> 
> But powerpc is subtle and I foresee that we have to kill __devinitconst
> and friends soonish.
> The problem is that despite data being const the compiler does not
> always mark the section const.
> So we will see a lot of the errors you see for powerpc now
> that we unconditionally specify a section.
> 
> Previously this inconsistentcy were hidden by the fact that powerpc tagets
> seldom were build without CONFIG_HOTPLUG=y.
> 
> So the patches are correct.
> Tomorrow I hope to do a patch that kill __devinitconst :-(
> 

hrm, OK.

> >  
> > -static const char version[] __devinitdata =
> > +static char version[] __devinitdata =
> >      "typhoon.c: version " DRV_MODULE_VERSION " (" DRV_MODULE_RELDATE ")\n";
> >  

but chances are that in a year's time someone will come along and helpfully
make this const again.  Maybe we should annotate such sites with

#define cant_make_me_const_ask_sam_why /**/

to avoid this..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/