Re: [PATCH] reduce large do_mount stack usage with noinlines

[Andrew Morton]

On Thu, 07 Feb 2008 17:08:19 -0600
Eric Sandeen <sandeen@xxxxxxxxxx> wrote:

> Index: linux-2.6.24-mm1/include/linux/compiler-gcc.h
> ===================================================================
> --- linux-2.6.24-mm1.orig/include/linux/compiler-gcc.h
> +++ linux-2.6.24-mm1/include/linux/compiler-gcc.h
> @@ -53,3 +53,9 @@
>  #define  noinline			__attribute__((noinline))
>  #define __attribute_const__		__attribute__((__const__))
>  #define __maybe_unused			__attribute__((unused))
> +
> +/*
> + * When gcc inlines multiple functions into a parent function,
> + * the stack space used sometimes increases excessively...
> + */
> +#define noinline_stackspace	noinline
> 
> 
> ?
> 
> I couldn't think of a great name for it.  There are several noinline
> users throughout the kernel with stackspace related comments, so if
> desired, I could sprinkle this around.  I'm not very pleased with it
> aesthetically though. :)

I think it's fine.  People can go look at the definition site, read the
comment and come away happy.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/