Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

[Badari Pulavarty]

On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote:
> On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote:
> > Hi Greg,
> > 
> > While playing with hotplug memory remove on 2.6.24-mm1, I 
> > noticed that /sysfs directory entries are not getting removed.
> > 
> > sysdev_unregister() used to call kobject_unregister().
> > But in 2.6.24-mm1, its only dropping the ref. It should
> > call kobject_del() to remove the object. Correct ?
> > 
> > With this change, the directories are getting removed
> > correctly. Comments ?
> 
> Ick, no, this shouldn't be needed, someone else must be holding a
> reference to the kobject device somewhere.  See the kobject documenation
> for more info.
> 
> I'll try to see where we grab 2 references...

I will take a closer look then. I was taking easy way out :(

Thanks,
Badari

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/