Re: [PATCH] scsi_error: Fix language abuse.

From: James Bottomley
Date: Fri Feb 08 2008 - 10:57:51 EST



On Fri, 2008-02-08 at 15:32 +0000, Alan Cox wrote:
> The word "illegal" has a precise dictionary meaning of "prohibited by
> law". The error messages are therefore incorrect as so far nobody has
> made SCSI violations a criminal offence.

Um, I'm really reluctant to do this without an incredibly good reason.
Illegal is a defined term under the SCSI standards, and the messages you
are changing actually appear with the word Illegal in the actual
ASC/ASCQ definition. If I accept this patch, you'll no longer be able
to look the messages up in the relevant standard:

http://www.t10.org/ftp/t10/drafts/spc3/spc3r23.pdf

By a simple text search.

I don't think the pedantry is worth the confusion ...

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/